Add an add_x86_only_kconfig_checks and an add_arm_only_kconfig_checks function #128
Conversation
… function Splitting the checks by arch family makes the code a tad more readable and self-contains, and makes it easier to inspect what checks are architecture-specific, instead of having the read the whole file.
|
Is this something you're interested in @a13xp0p0v? Otherwise, I won't spend time resolving conflicts :) |
a13xp0p0v
force-pushed
the
master
branch
2 times, most recently
from
ea24300 to
78f5595
Compare
|
Hello @jvoisin, This branch breaks the current order of the checks. Let me describe the rationale, maybe we will create a better solution. First, all checks in
In each
In each
This ordering of the checks in We also discussed this with @asarubbo in #113. Does it sound reasonable? |
|
I think it depends what we want to optimize for, code-wise: do we think it's easier to group checks by reason, or by architecture. I think the latter is more desirable, grouping by reason also makes sense. What would be nice would be to actually group the checks, either in |
|
By the way, I guess this refactoring will allow to do easy alphabetical sorting inside each group. |
That's the plan :> |
|
It's a big and important refactoring. |
a13xp0p0v
added
planned_after_release
a13xp0p0v
removed
the
planned_after_release
Splitting the checks by arch family makes the code a tad more readable and self-contains, and makes it easier to inspect what checks are architecture-specific, instead of having the read the whole file.